Skip to content

mtu: Catch expected error in endpoint MTU updater #36596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

mtu: Catch expected error in endpoint MTU updater #36596

merged 1 commit into from
Mar 13, 2025

Conversation

dylandreimerink
Copy link
Member

@dylandreimerink dylandreimerink commented Dec 13, 2024 •
edited
Loading

There are a number of errors which we expect to occur when updating the
MTU of an endpoint while its being deleted. This commit adds checks to
catch and ignore these errors.

Fixes: #36590

@dylandreimerink dylandreimerink added the release-note/misc This PR makes changes that have no direct user impact. label Dec 13, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 13, 2025
@dylandreimerink dylandreimerink force-pushed the feature/remove-expected-mtu-updater-logs branch from 6005f76 to dee71ab Compare January 27, 2025 14:03
@dylandreimerink
Copy link
Member Author

/test

@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 28, 2025
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Feb 27, 2025
@dylandreimerink dylandreimerink force-pushed the feature/remove-expected-mtu-updater-logs branch from dee71ab to 8a6db71 Compare March 11, 2025 10:53
@dylandreimerink
mtu: Catch expected error in endpoint MTU updater
cb94491 
There are a number of errors which we expect to occur when updating the
MTU of an endpoint while its being deleted. This commit adds checks to
catch and ignore these errors.

Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
@dylandreimerink dylandreimerink force-pushed the feature/remove-expected-mtu-updater-logs branch from 8a6db71 to cb94491 Compare March 11, 2025 14:57
@dylandreimerink dylandreimerink changed the title mtu: Ignore link errors instead of logging and health degradation mtu: Catch expected error in endpoint MTU updater Mar 11, 2025
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Mar 12, 2025
@dylandreimerink
Copy link
Member Author

/test

@dylandreimerink dylandreimerink marked this pull request as ready for review March 12, 2025 15:50
@dylandreimerink dylandreimerink requested a review from a team as a code owner March 12, 2025 15:50
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 13, 2025
@dylandreimerink dylandreimerink added this pull request to the merge queue Mar 13, 2025
Merged via the queue into cilium:main with commit 2a74733 Mar 13, 2025
71 checks passed
@dylandreimerink dylandreimerink deleted the feature/remove-expected-mtu-updater-logs branch March 13, 2025 09:59
@dylandreimerink dylandreimerink added the needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch label May 21, 2025
@joamaki joamaki mentioned this pull request May 23, 2025
Merged
6 tasks
@joamaki joamaki added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels May 23, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschwinger233 jschwinger233 jschwinger233 approved these changes

Assignees
No one assigned
Labels
backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
3 participants
@dylandreimerink @jschwinger233 @joamaki