cilium-cli: Add envoy log pattern in error check #36498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marseel
reviewed
Dec 11, 2024
christarazi
approved these changes
Dec 11, 2024
|
/test |
|
Seems like this PR surfaces an existing issue, which we need to check before proceed. Marking this as draft. |
sayboras
added a commit
that referenced
this pull request
Dec 19, 2024
Each stable releases might run with different cilium/proxy versions, which might cause below error logs during upgrade/downgrade tests. This commit is to disable such validation, as any incompatibility issue will trigger connectivity failure. Additionally, any error logs in cilium envoy pod will be checked after #36498 is merged. ``` time=2024-12-19T15:02:09Z level=error msg="Timer job errored" module=agent.controlplane.envoy-proxy name=version-check func="envoy.registerEnvoyVersionCheck.func2 (pkg/envoy/cell.go:279)" error="envoy version 3a8ccd54545785689e677d785b69025d1d4b33de/1.31.4/Distribution/RELEASE/BoringSSL does not match with required version fff09f16c2c269b22509c86dfc1d3e8f52eb3857" (1 occurrences) ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Each stable releases might run with different cilium/proxy versions, which might cause below error logs during upgrade/downgrade tests. This commit is to disable such validation, as any incompatibility issue will trigger connectivity failure. Additionally, any error logs in cilium envoy pod will be checked after #36498 is merged. ``` time=2024-12-19T15:02:09Z level=error msg="Timer job errored" module=agent.controlplane.envoy-proxy name=version-check func="envoy.registerEnvoyVersionCheck.func2 (pkg/envoy/cell.go:279)" error="envoy version 3a8ccd54545785689e677d785b69025d1d4b33de/1.31.4/Distribution/RELEASE/BoringSSL does not match with required version fff09f16c2c269b22509c86dfc1d3e8f52eb3857" (1 occurrences) ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
that referenced
this pull request
Dec 19, 2024
[ upstream commit 4a461ae ] Each stable releases might run with different cilium/proxy versions, which might cause below error logs during upgrade/downgrade tests. This commit is to disable such validation, as any incompatibility issue will trigger connectivity failure. Additionally, any error logs in cilium envoy pod will be checked after #36498 is merged. ``` time=2024-12-19T15:02:09Z level=error msg="Timer job errored" module=agent.controlplane.envoy-proxy name=version-check func="envoy.registerEnvoyVersionCheck.func2 (pkg/envoy/cell.go:279)" error="envoy version 3a8ccd54545785689e677d785b69025d1d4b33de/1.31.4/Distribution/RELEASE/BoringSSL does not match with required version fff09f16c2c269b22509c86dfc1d3e8f52eb3857" (1 occurrences) ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
that referenced
this pull request
Dec 20, 2024
[ upstream commit 4a461ae ] Each stable releases might run with different cilium/proxy versions, which might cause below error logs during upgrade/downgrade tests. This commit is to disable such validation, as any incompatibility issue will trigger connectivity failure. Additionally, any error logs in cilium envoy pod will be checked after #36498 is merged. ``` time=2024-12-19T15:02:09Z level=error msg="Timer job errored" module=agent.controlplane.envoy-proxy name=version-check func="envoy.registerEnvoyVersionCheck.func2 (pkg/envoy/cell.go:279)" error="envoy version 3a8ccd54545785689e677d785b69025d1d4b33de/1.31.4/Distribution/RELEASE/BoringSSL does not match with required version fff09f16c2c269b22509c86dfc1d3e8f52eb3857" (1 occurrences) ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
[ upstream commit 4a461ae ] Each stable releases might run with different cilium/proxy versions, which might cause below error logs during upgrade/downgrade tests. This commit is to disable such validation, as any incompatibility issue will trigger connectivity failure. Additionally, any error logs in cilium envoy pod will be checked after #36498 is merged. ``` time=2024-12-19T15:02:09Z level=error msg="Timer job errored" module=agent.controlplane.envoy-proxy name=version-check func="envoy.registerEnvoyVersionCheck.func2 (pkg/envoy/cell.go:279)" error="envoy version 3a8ccd54545785689e677d785b69025d1d4b33de/1.31.4/Distribution/RELEASE/BoringSSL does not match with required version fff09f16c2c269b22509c86dfc1d3e8f52eb3857" (1 occurrences) ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
Cilium Envoy might be running as Daemonset mode, which will have its own log format. Just a note that cilium-envoy logs are already retrieved as part of label selector app.kubernetes.io/part-of=cilium. Relates: #36259 Signed-off-by: Tam Mach <tam.mach@cilium.io>
a6d4091 to
a7ce8af
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cilium Envoy might be running as Daemonset mode, which will have its own log format. Just a note that cilium-envoy logs are already retrieved as part of label selector app.kubernetes.io/part-of=cilium.
Relates: #36259