service: Cap number of backends included in monitor message #36394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the number of backends included in the ServiceUpsertMessage to avoid performing significant amount of allocations for services with lots of backends and churn. The number of omitted backends is included in the monitor message. Signed-off-by: Jussi Maki <jussi@isovalent.com>
f6d7073 to
08a343e
Compare
|
/test |
ysksuzuki
approved these changes
Dec 12, 2024
kaworu
approved these changes
Dec 13, 2024
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the number of backends included in the ServiceUpsertMessage to avoid performing significant amount of allocations for services with lots of backends and churn. The number of omitted backends is included in the monitor message.
This is the second part of addressing a significant memory "leak" issue with services that have lots of backends. The root problem was the Hubble ring buffer holding onto lots of ServiceUpsertNotifications, which is fixed in #36391. After 36391 the remaining use-case for the service messages is just
cilium-dbg monitor, so there isn't too much of a point to doing lots of work to generate the message.