-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Test #36359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Test #36359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6e597b
to
1fcd96a
Compare
e39be24
to
24030e6
Compare
9b3abdf
to
fc6df72
Compare
e3e760b
to
5b14953
Compare
46d8388
to
9fdc120
Compare
4e1704c
to
db84e76
Compare
db84e76
to
d57c518
Compare
This comment was marked as resolved.
This comment was marked as resolved.
d57c518
to
b8771a0
Compare
b8771a0
to
362cd95
Compare
e9bb6e3
to
dfb1e96
Compare
This commit extends our local node logic to return the IPv6 node address for CiliumEndpoint objects whenever the underlay is set to IPv6. This is necessary to have the IPv6 address when populating the tunnel endpoint in the ipcache. Otherwise, on dual-stack clusters, we would always end up with the IPv4 address in CiliumEndpoints. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
The previous commit introduced a Hive dependency loop between the tunnel package, the node store and the egress gateway manager: failed to start: cycle detected in dependency graph: [scope "pprof"] func(node.LocalNodeStoreParams) (*node.LocalNodeStore, error) provided by "github.com/cilium/cilium/pkg/node".NewLocalNodeStore (/go/src/github.com/cilium/cilium/pkg/node/local_node_store.go:110) depends on func(cmd.localNodeSynchronizerParams) node.LocalNodeSynchronizer provided by "github.com/cilium/cilium/daemon/cmd".newLocalNodeSynchronizer (/go/src/github.com/cilium/cilium/daemon/cmd/local_node_sync.go:97) depends on func(tunnel.newConfigIn) (tunnel.Config, error) provided by "github.com/cilium/cilium/pkg/datapath/tunnel".newConfig (/go/src/github.com/cilium/cilium/pkg/datapath/tunnel/tunnel.go:83) depends on func(egressgateway.Params) (struct { dig.Out; *egressgateway.Manager; defines.NodeOut; tunnel.EnablerOut }, error) provided by "github.com/cilium/cilium/pkg/egressgateway".NewEgressGatewayManager (/go/src/github.com/cilium/cilium/pkg/egressgateway/manager.go:165) depends on func(identitycachecell.identityAllocatorParams) identitycachecell.identityAllocatorOut provided by "github.com/cilium/cilium/pkg/identity/cache/cell".newIdentityAllocator (/go/src/github.com/cilium/cilium/pkg/identity/cache/cell/cell.go:111) depends on func(endpointmanager.endpointManagerParams) endpointmanager.endpointManagerOut provided by "github.com/cilium/cilium/pkg/endpointmanager".newDefaultEndpointManager (/go/src/github.com/cilium/cilium/pkg/endpointmanager/cell.go:228) depends on func(node.LocalNodeStoreParams) (*node.LocalNodeStore, error) provided by "github.com/cilium/cilium/pkg/node".NewLocalNodeStore (/go/src/github.com/cilium/cilium/pkg/node/local_node_store.go:110) This commit works around the dependency loop. Co-authored-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
Commit 7cc1d53 ("mtu: Support tunneling over IPv6 in calculations") adjusted the MTU calculation to take IPv6 underlays into account. But because this commit was written before the underlay-protocol flag was introduced, it simply assumed that we're in IPv6 underlay mode if tunneling is enabled but IPv4 isn't. That however doesn't work for dual-stack clusters with IPv6 underlay. The present commit fixes it to use the underlay-protocol flag. Fixes: 7cc1d53 ("mtu: Support tunneling over IPv6 in calculations") Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
This commit switches one of the existing dual-stack configuration to use an IPv6 underlay, to test subsequent changes in dual-stack mode (where we can run more connectivity tests). Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
dfb1e96
to
7c82fc1
Compare
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
7c82fc1
to
7169f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/ipv6-only
Relates to single-stack IPv6 support.
feature/ipv6
Relates to IPv6 protocol support
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: