cilium-cli: Derive the default version from cilium/charts #36344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derive the default Cilium version from the source using vendored cilium/charts instead of injecting it at compile time. This helps ensure that the default version is consistent across all the downstream cilium-cli packages. Fixes: cilium/cilium-cli#2870 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
|
✅ |
|
@tklauser something like this for cilium-cli release note entry 🚀🙏
|
|
/test |
squeed
approved these changes
Dec 4, 2024
brlbil
approved these changes
Dec 4, 2024
|
@michi-covalent The suggested release note was not included it seems? Just has the github autogenerated ones. |
|
oh yeah thanks for the heads up. tobias, i updated the release notes here => https://github.com/cilium/cilium-cli/releases/tag/v0.16.21 🚀🙏 |
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Dec 9, 2024
Now Cilium CLI sets the default Cilium version without relying on the compile-time flag [^1]. [^1]: cilium/cilium#36344 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
tklauser
pushed a commit
to cilium/cilium-cli
that referenced
this pull request
Dec 10, 2024
Now Cilium CLI sets the default Cilium version without relying on the compile-time flag [^1]. [^1]: cilium/cilium#36344 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Feb 28, 2025
- Include the top-level Makefile.defs, and re-use GO and INSTALL variables. - Remove unused THIS_DIR variable [^1]. - Explicitly set GO_BUILD_LDFLAGS variable. Cilium and Cilium CLI use different Go build flags. [^1]: #36344 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Feb 28, 2025
- Include the top-level Makefile.defs, and re-use GO and INSTALL variables. - Remove unused THIS_DIR variable [^1]. - Explicitly set BINDIR and GO_BUILD_LDFLAGS variable. Cilium and Cilium CLI use different values for these settings. [^1]: #36344 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
- Include the top-level Makefile.defs, and re-use GO and INSTALL variables. - Remove unused THIS_DIR variable [^1]. - Explicitly set BINDIR and GO_BUILD_LDFLAGS variable. Cilium and Cilium CLI use different values for these settings. [^1]: #36344 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive the default Cilium version from the source using vendored cilium/charts instead of injecting it at compile time. This helps ensure that the default version is consistent across all the downstream cilium-cli packages.
Fixes: cilium/cilium-cli#2870