cilium-cli/connectivity: allow to specify log levels to check #36231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dce1e60 to
ff689f4
Compare
|
/test |
Since commit 5417a3f ("cli/connectivity: Check for unexpected warning logs") we check for unexpected warnings in logs as part of the connectivity checks. This leads to some fallout in cilium/cilium-cli when pulling in that change[^1] for the upcoming cilium-cli v0.16.21 release, mainly due to the fact that Hubble and Hubble UI are enabled in the cilium/cilium-cli workflows. To work around that and don't block the next release of cilium-cli for too long, allow to specify log levels to check by means of a hidden flag (by default, errors and warnings are both still checked). This allows to skip checking of warnings logs temporarily. In the long term all these warning logs should be addressed by either fixing their root cause, demoting their level or adding them to the ignore list. [^1]: cilium/cilium-cli#2869 Signed-off-by: Tobias Klauser <tobias@cilium.io>
ff689f4 to
aa81725
Compare
|
/test |
pchaigno
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 5417a3f ("cli/connectivity: Check for unexpected warning logs") we check for unexpected warnings in logs as part of the connectivity checks. This leads to some fallout in cilium/cilium-cli when pulling in that change1 for the upcoming cilium-cli v0.16.21 release, mainly due to the fact that Hubble and Hubble UI are enabled in the cilium/cilium-cli workflows.
To work around that and don't block the next release of cilium-cli for too long, allow to specify log levels to check by means of a hidden flag (by default, errors and warnings are both still checked). This allows to skip checking of warnings logs temporarily. In the long term all these warning logs should be addressed by either fixing their root cause, demoting their level or adding them to the ignore list.
/cc @pchaigno
Footnotes
https://github.com/cilium/cilium-cli/pull/2869 ↩