Skip to content

bgpv1: populate locally available services after performing svc diff #36230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

bgpv1: populate locally available services after performing svc diff #36230

merged 1 commit into from
Nov 28, 2024

Conversation

rastislavs
Copy link
Contributor

@rastislavs rastislavs commented Nov 28, 2024 •
edited
Loading

To prevent potential race during service reconciliation, move populating of locally available services (epDiffStore.List()) after performing service diff reconciliation (epDiffStore.Diff).

Related: #36055

(BGPv2 already fixed in #36165)

BGPv1: Fix race by reconciliation of services with externalTrafficPolicy=Local by populating locally available services after performing service diff

@rastislavs
bgpv1: populate locally available services after performing svc diff
98520b8 
To prevent potential race during service reconciliation, move
populating of locally available services (epDiffStore.List())
after performing service diff reconciliation (epDiffStore.Diff).

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@rastislavs rastislavs added release-note/bug This PR fixes an issue in a previous release of Cilium. area/bgp Impacts the Border Gateway Protocol feature. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 28, 2024
@rastislavs
Copy link
Contributor Author

/test

@rastislavs rastislavs marked this pull request as ready for review November 28, 2024 12:21
@rastislavs rastislavs requested a review from a team as a code owner November 28, 2024 12:21
harsimran-pabla
harsimran-pabla approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@harsimran-pabla harsimran-pabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 28, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Nov 28, 2024
Merged via the queue into cilium:main with commit 5f12e5a Nov 28, 2024
70 checks passed
@nbusseneau nbusseneau mentioned this pull request Dec 1, 2024
Merged
8 tasks
@nbusseneau nbusseneau added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Dec 1, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 3, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsimran-pabla harsimran-pabla harsimran-pabla approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rastislavs @harsimran-pabla @nbusseneau @julianwiedmann