Export Map{Key,Value} fields to prevent map {get,list} handler panics.
#36219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
6b574c9 to
22fcb3d
Compare
map {get,list} handler panics.
|
/test |
The `cilium-dbg map {get,list}` open-api handler will generically try to
unpack bpf map data into their respective key/value pairs.
However, if the Map{Key,Value} structs have unexported fields this will
panic causing the following errors:
level=warning msg="Cilium API handler panicked" client=@ method=GET panic_message="reflect: reflect.Value.SetUint using value obtained using unexported field" subsys=api url=/v1/map
This can be reproduced by enabling a feature that uses such a map, such
as `socketLB.enabled=true`, followed by doing a map list:
```
root@kind-worker:/home/cilium# cilium map list
Error: Get "http://localhost/v1/map": EOF
```
This commit exports any unexported fields in types used as key/values in
pkg/maps to avoid such errors.
Fixes: #33766
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
22fcb3d to
0412cb6
Compare
|
/test |
jibi
approved these changes
Nov 29, 2024
|
The linked issue says this also affects v1.16, setting |
|
👋 @tommyp1ckles Backporter here. Double checking whether this PR should be backported to v1.16 or the label should be dropped. |
@tommyp1ckles ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/maps/*: export Map{Key,Value} fields to fix cilium-dbg panics.
The
cilium-dbg map {get,list}open-api handler will generically try tounpack bpf map data into their respective key/value pairs.
However, if the Map{Key,Value} structs have unexported fields this will
panic causing the following errors:
level=warning msg="Cilium API handler panicked" client=@ method=GET panic_message="reflect: reflect.Value.SetUint using value obtained using unexported field" subsys=api url=/v1/map
This can be reproduced by enabling a feature that uses such a map, such
as
socketLB.enabled=true, followed by doing a map list:This commit exports any unexported fields in types used as key/values in
pkg/maps to avoid such errors.
Fixes: #33766