Skip to content

fix: dynamicSizeRatio in "Memory available for map entries" log message #36211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: dynamicSizeRatio in "Memory available for map entries" log message #36211

merged 1 commit into from
Nov 28, 2024

Conversation

jingyuanliang
Copy link
Contributor

@jingyuanliang jingyuanliang commented Nov 27, 2024 •
edited
Loading

It's displayed as a percentage so the value should be multiplied by 100.

Tested:

{"level":"info", "msg":"Memory available for map entries (0.250% of 16776097792B): 41940244B", "subsys":"config"}

@jingyuanliang jingyuanliang requested review from a team as code owners November 27, 2024 17:39
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 27, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 27, 2024
@jingyuanliang
fix: dynamicSizeRatio in "Memory available for map entries" log message
b92c373 
It's displayed as a percentage so the value should be multiplied by 100.

Signed-off-by: Jingyuan Liang <jingyuanliang@google.com>
@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/agent Cilium agent related. labels Nov 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 28, 2024
mhofstetter
mhofstetter approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@mhofstetter
Copy link
Member

/test

@tklauser tklauser enabled auto-merge November 28, 2024 08:15
@tklauser tklauser added this pull request to the merge queue Nov 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 28, 2024
Merged via the queue into cilium:main with commit d54be30 Nov 28, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

Assignees
No one assigned
Labels
area/agent Cilium agent related. kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingyuanliang @mhofstetter @tklauser