Skip to content

Conversation

aanm
Copy link
Member

@aanm aanm commented Nov 27, 2024

Refactored some metric names and added a new namespace "controlplane" to distinguish between controlplane and datapath features.

Suggested-by: Joe Stringer joe@cilium.io

Refactored some metric names and added a new namespace "controlplane" to
distinguish between controlplane and datapath features.

Suggested-by: Joe Stringer <joe@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added area/CI Continuous Integration testing issue or flake area/metrics Impacts statistics / metrics gathering, eg via Prometheus. release-note/misc This PR makes changes that have no direct user impact. labels Nov 27, 2024
@aanm aanm requested a review from joestringer November 27, 2024 15:40
@aanm aanm requested a review from a team as a code owner November 27, 2024 15:40
@aanm
Copy link
Member Author

aanm commented Nov 27, 2024

/test

@aanm aanm enabled auto-merge November 27, 2024 15:40
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@aanm aanm added this pull request to the merge queue Nov 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 28, 2024
Merged via the queue into main with commit f81fddb Nov 28, 2024
278 of 279 checks passed
@aanm aanm deleted the pr/aanm/features-4 branch November 28, 2024 09:58
@aanm aanm added needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 29, 2024
@aanm aanm added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 16, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 16, 2024
@aanm aanm mentioned this pull request Dec 17, 2024
14 tasks
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Dec 18, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/metrics Impacts statistics / metrics gathering, eg via Prometheus. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants