Skip to content

Update basic-https.yaml #36207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

Update basic-https.yaml #36207

merged 1 commit into from
Nov 28, 2024

Conversation

sajjadjafaribojd
Copy link
Contributor

@sajjadjafaribojd sajjadjafaribojd commented Nov 27, 2024 •
edited
Loading

Certificate in ca-issuer.yaml in this address https://raw.githubusercontent.com/cilium/cilium/1.16.4/examples/kubernetes/servicemesh/ca-issuer.yaml must be ca and demo-cert does not work.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@sajjadjafaribojd
Update basic-https.yaml
721d5c5 
Certificate in ca-issuer.yaml in this address https://raw.githubusercontent.com/cilium/cilium/1.16.4/examples/kubernetes/servicemesh/ca-issuer.yaml is `ca` and `demo-cert` does not work.

Signed-off-by: JabJ <sajjadjafaribojd@gmail.com>
@sajjadjafaribojd sajjadjafaribojd requested a review from a team as a code owner November 27, 2024 14:03
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 27, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 27, 2024
@aanm
Copy link
Member

aanm commented Nov 28, 2024

/test

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Nov 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 28, 2024
@aanm aanm enabled auto-merge November 28, 2024 14:16
@aanm aanm added this pull request to the merge queue Nov 28, 2024
Merged via the queue into cilium:main with commit 0b489ef Nov 28, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@youngnick youngnick Awaiting requested review from youngnick youngnick is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sajjadjafaribojd @aanm