cilium: per service algorithm follow-ups #36204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfb5580 to
d70f4c3
Compare
Extend host port docs to clarify that it reuses default service handling behavior. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Small cleanups and code style tweaks. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
We cannot extend structs based on defines to enlarge them as this compromises the ongoing work to achieve a clang-free Cilium runtime image, or at least makes it significantly harder. Therefore use the upper 8 bits of the affinity timeout field in the service master entry. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: #35735 (comment)
We have several variants in the agent code: Alg, Algo, Algorithm. Streamline this to Algorithm consistently. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
293742e to
9aa5c10
Compare
a3a1ad0 to
25adac0
Compare
1) It's not needed since only the master service entry needs this, and 2) It will become buggy when we move the LB algorithm into the affinity timeout since that field is a union. For backend entries in the service map this contains the backend IDs. If this stays as-is we end up corrupting them. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
25adac0 to
1c86330
Compare
Add a corresponding Helm option to enable the per-service load balancing algorithm annotation. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Add docs and usage examples. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
a271490 to
b7ca0b3
Compare
|
/test |
tklauser
approved these changes
Nov 29, 2024
dylandreimerink
approved these changes
Nov 29, 2024
nbusseneau
approved these changes
Nov 29, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See commit desc)
Fixes: #36112