endpoint: fix panic if restored endpoint does no longer exist in k8s #36292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blamed commit was intended to silence not found errors during restoration, which are expected if the corresponding pod has been deleted asynchronously while the agent was down. However, it mistakenly modified the execution flow, breaking out of the switch (rather than returning) and eventually leading to accessing a nil pointer, with the obvious ill-fated consequences. Let's fix this by restoring the original execution flow, and add a dedicated unit test to prevent regressions. Fixes: 40130c7 ("endpoint: silence metadata resolver not found errors during restoration") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
squeed
reviewed
Dec 2, 2024
squeed
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blamed commit was intended to silence not found errors during restoration, which are expected if the corresponding pod has been deleted asynchronously while the agent was down. However, it mistakenly modified the execution flow, breaking out of the switch (rather than returning) and eventually leading to accessing a nil pointer, with the obvious ill-fated consequences.
Let's fix this by restoring the original execution flow, and add a dedicated unit test to prevent regressions.
Fixes: 40130c7 ("endpoint: silence metadata resolver not found errors during restoration")