Skip to content

Conversation

rastislavs
Copy link
Contributor

@rastislavs rastislavs commented Nov 29, 2024

As some k8s errors are known to be transient and likely to resolve upon next reconciliation attempt, do not log warnings upon these errors upon each reconcile, only once after 5 retries.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 29, 2024
@rastislavs rastislavs added the release-note/misc This PR makes changes that have no direct user impact. label Nov 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 29, 2024
@rastislavs
Copy link
Contributor Author

/test

@rastislavs rastislavs marked this pull request as ready for review November 29, 2024 13:09
@rastislavs rastislavs requested a review from a team as a code owner November 29, 2024 13:09
As some k8s errors are known to be transient and likely
to resolve upon next reconciliation attempt. Do not log warnings upon
these errors upon each reconcile, only once after 5 retries.

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@rastislavs rastislavs changed the title operator/bgpv2: Do not warn upon common transient k8s errors operator/bgpv2: Relax warnings upon transient k8s errors Nov 29, 2024
@rastislavs
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 29, 2024
@nbusseneau nbusseneau added this pull request to the merge queue Nov 29, 2024
Merged via the queue into cilium:main with commit c93029c Nov 29, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants