Skip to content

bgpv2: Fix the wrong termination condition of cleanup-peer-config-status #36245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

bgpv2: Fix the wrong termination condition of cleanup-peer-config-status #36245

merged 1 commit into from
Nov 29, 2024

Conversation

YutaroHayakawa
Copy link
Member 

bgpv2: Fix the wrong termination condition of cleanup-peer-config-status

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 29, 2024
@YutaroHayakawa YutaroHayakawa added the release-note/misc This PR makes changes that have no direct user impact. label Nov 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 29, 2024
@YutaroHayakawa
Copy link
Member Author

/test

@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review November 29, 2024 06:32
@YutaroHayakawa YutaroHayakawa requested a review from a team as a code owner November 29, 2024 06:32
rastislavs
rastislavs approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@YutaroHayakawa @rastislavs
bgpv2: Fix the wrong termination condition of cleanup-peer-config-status
87f6ea5 
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@rastislavs rastislavs force-pushed the bgp-status-report-fix branch from 8709b28 to 87f6ea5 Compare November 29, 2024 11:43
@rastislavs
Copy link
Contributor

(rebased as the PR was hitting a permanent CI failure fixed in the meantime)

@rastislavs
Copy link
Contributor

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 29, 2024
@aanm aanm added this pull request to the merge queue Nov 29, 2024
Merged via the queue into cilium:main with commit 7d3c368 Nov 29, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YutaroHayakawa @rastislavs @aanm