Skip to content

bgpv2: Status reporting document #36134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

bgpv2: Status reporting document #36134

merged 1 commit into from
Nov 26, 2024

Conversation

YutaroHayakawa
Copy link
Member

Document recently added status conditions and bgpControlPlane.statusReport.enabled flag.

bgpv2: Status reporting document

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 25, 2024
@YutaroHayakawa YutaroHayakawa added the release-note/misc This PR makes changes that have no direct user impact. label Nov 25, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 25, 2024
@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review November 25, 2024 07:35
@YutaroHayakawa YutaroHayakawa requested review from a team as code owners November 25, 2024 07:35
@YutaroHayakawa YutaroHayakawa requested review from rastislavs and a user November 25, 2024 07:35
@YutaroHayakawa
Copy link
Member Author

/test

rastislavs
rastislavs approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nit, thanks!

@julianwiedmann julianwiedmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/bgp Impacts the Border Gateway Protocol feature. labels Nov 25, 2024
@YutaroHayakawa YutaroHayakawa force-pushed the bgp-status-reporting-doc branch from cc27adc to da177f2 Compare November 25, 2024 12:40
@zacharysarah zacharysarah force-pushed the bgp-status-reporting-doc branch from da177f2 to 0c01b9f Compare November 25, 2024 20:15
zacharysarah
zacharysarah reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YutaroHayakawa Nice work. ⭐ The one set of changes I recommend is nice to have but not blocking.

@YutaroHayakawa YutaroHayakawa force-pushed the bgp-status-reporting-doc branch from 0c01b9f to 532798e Compare November 26, 2024 02:28
@YutaroHayakawa
bgpv2: Status reporting document
a9a8de0 
Document recently added status conditions and
bgpControlPlane.statusReport.enabled flag.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@YutaroHayakawa YutaroHayakawa force-pushed the bgp-status-reporting-doc branch from 532798e to a9a8de0 Compare November 26, 2024 02:31
@YutaroHayakawa
Copy link
Member Author

/test

@YutaroHayakawa YutaroHayakawa added this pull request to the merge queue Nov 26, 2024
Merged via the queue into cilium:main with commit 8f64334 Nov 26, 2024
59 checks passed
@YutaroHayakawa YutaroHayakawa deleted the bgp-status-reporting-doc branch November 26, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah left review comments

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YutaroHayakawa @zacharysarah @rastislavs @julianwiedmann