cli: Don't ignore datapath bug packet drops #36105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ca135c to
5dc6158
Compare
Packet drops with reason "No tunnel/encapsulation endpoint (datapath BUG!)" look highly suspicious. Yet, I allowlisted it in CI in commit [1] and didn't explain where it was seen 😬 This commit removes it from the list of packet drops that are expected in CI. It doesn't seem to be occurring anymore, so maybe it was just my mistake. And if it ever happens again in CI, it's definitely something we'll want to investigate. 1 - cilium/cilium-cli@4d0d9bf Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
5dc6158 to
d8d6724
Compare
|
/test |
tklauser
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packet drops with reason
No tunnel/encapsulation endpoint (datapath BUG!)look highly suspicious. Yet, I allowlisted it in CI in commit 4d0d9bf15df9 ("defaults: Add expected drop reasons") and didn't explain where it was seen 😬This pull request removes it from the list of packet drops that are expected in CI. It doesn't seem to be occurring anymore, so maybe it was just my mistake. And if it ever happens again in CI, it's definitely something we'll want to investigate.