-
Notifications
You must be signed in to change notification settings - Fork 3.4k
bgp: remove metallb bgp ginkgo tests #36192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
323d578
to
b3695f6
Compare
/test |
b3695f6
to
51f4b39
Compare
/test |
Removing metallb ginkgo test since we are going to remove metallb-bgp integration from cilium. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
51f4b39
to
9394f90
Compare
/test |
Restart Cilium agent before starting chaos test suite as there can be cases where other tests before chaos test leave Cilium in broken state. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
9394f90
to
675655b
Compare
/test |
rastislavs
approved these changes
Nov 28, 2024
brlbil
approved these changes
Nov 28, 2024
nebril
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/bgp
Impacts the Border Gateway Protocol feature.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit:
Removing metallb bgp ginkgo tests as we will be removing metall-bgp integration code from Cilium.
Related to: #36191
Second commit:
With above changes, looks like ordering of ci-runtime test changed and chaos test starting running as the last test case and started consistently failing. To solve it, change is to restart Cilium before starting chaos test suite.