Skip to content

Conversation

harsimran-pabla
Copy link
Contributor

@harsimran-pabla harsimran-pabla commented Nov 26, 2024

First commit:
Removing metallb bgp ginkgo tests as we will be removing metall-bgp integration code from Cilium.
Related to: #36191

Second commit:
With above changes, looks like ordering of ci-runtime test changed and chaos test starting running as the last test case and started consistently failing. To solve it, change is to restart Cilium before starting chaos test suite.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 26, 2024
@harsimran-pabla harsimran-pabla added release-note/misc This PR makes changes that have no direct user impact. area/bgp Impacts the Border Gateway Protocol feature. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 26, 2024
@harsimran-pabla harsimran-pabla force-pushed the hpabla/remove-metallb-bgp-tests branch 2 times, most recently from 323d578 to b3695f6 Compare November 26, 2024 19:06
@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla harsimran-pabla force-pushed the hpabla/remove-metallb-bgp-tests branch from b3695f6 to 51f4b39 Compare November 27, 2024 14:40
@harsimran-pabla
Copy link
Contributor Author

/test

Removing metallb ginkgo test since we are going to remove metallb-bgp
integration from cilium.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla force-pushed the hpabla/remove-metallb-bgp-tests branch from 51f4b39 to 9394f90 Compare November 27, 2024 16:55
@harsimran-pabla
Copy link
Contributor Author

/test

Restart Cilium agent before starting chaos test suite as there can be
cases where other tests before chaos test leave Cilium in broken state.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla force-pushed the hpabla/remove-metallb-bgp-tests branch from 9394f90 to 675655b Compare November 27, 2024 18:34
@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla harsimran-pabla marked this pull request as ready for review November 27, 2024 20:39
@harsimran-pabla harsimran-pabla requested review from a team as code owners November 27, 2024 20:39
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 28, 2024
@brb brb added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 3f46e4e Nov 28, 2024
282 of 283 checks passed
@brb brb deleted the hpabla/remove-metallb-bgp-tests branch November 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp Impacts the Border Gateway Protocol feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants