Skip to content

BGP: Removing metallb BGP integration #36191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2024
Merged

BGP: Removing metallb BGP integration #36191

merged 2 commits into from
Dec 3, 2024

Conversation

harsimran-pabla
Copy link
Contributor

Metallb BGP integration in Cilium has been deprecated since v1.14 release. Original issue for deprecation tracking #22246.

Announcement to OSS community: https://cilium.slack.com/archives/C06HL734BM5/p1731082755110609

Migration path to Cilium BGP Control Plane: https://isovalent.com/blog/post/migrating-from-metallb-to-cilium/

bgp: remove metallb bgp integration.

@harsimran-pabla harsimran-pabla added release-note/major This PR introduces major new functionality to Cilium. area/bgp Impacts the Border Gateway Protocol feature. labels Nov 26, 2024
@harsimran-pabla harsimran-pabla mentioned this pull request Nov 26, 2024
Merged
@harsimran-pabla harsimran-pabla force-pushed the hpabla/remove-metallb-bgp branch 3 times, most recently from 3f4a915 to 9db34d3 Compare November 26, 2024 19:30
@harsimran-pabla
bgp: remove metallb bgp integration
6908f5d 
Removing metallb BGP integration from Cilium. Metallb BGP has been
deprecated from v1.14, users should use Cilium BGP Control Plane for BGP
support in Cilium.

Migration is documented in this blog post
https://isovalent.com/blog/post/migrating-from-metallb-to-cilium/

Issue: cilium#22246

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla
bgp: remove metallb bgp helm values and config map
56a3559 
Removing metallb BGP flags
- BGPAnnouncePodCIDR
- BGPAnnounceLBIP

Also, removing reference to BGP config map.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla force-pushed the hpabla/remove-metallb-bgp branch from 9db34d3 to 56a3559 Compare November 28, 2024 14:49
@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla harsimran-pabla marked this pull request as ready for review November 28, 2024 16:32
@harsimran-pabla harsimran-pabla requested review from a team as code owners November 28, 2024 16:33
michi-covalent
michi-covalent approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on cli change. i'm guessing there will be another PR to update the documentation? 📝

@harsimran-pabla
Copy link
Contributor Author

harsimran-pabla commented Nov 28, 2024 •
edited
Loading

i'm guessing there will be another PR to update the documentation?

I wanted to get this out asap before 1.17 feature freeze. Docs update is coming out next.

rastislavs
rastislavs approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Thanks!

mhofstetter
mhofstetter approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks! 🎉

bimmlerd
bimmlerd approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

marseel
marseel approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

gandro
gandro reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note in the upgrade docs please?

Edit: Apologies, I missed the comment above. Approving now

@harsimran-pabla harsimran-pabla mentioned this pull request Dec 2, 2024
Merged
derailed
derailed approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harsimran-pabla Nice work!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 2, 2024
@sayboras sayboras added this pull request to the merge queue Dec 3, 2024
Merged via the queue into cilium:main with commit e645d1f Dec 3, 2024
100 checks passed
@tklauser tklauser mentioned this pull request Dec 12, 2024
Closed
@cilium-release-bot cilium-release-bot bot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@gandro gandro gandro approved these changes

@marseel marseel marseel approved these changes

@mhofstetter mhofstetter mhofstetter approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

@youngnick youngnick youngnick approved these changes

@rastislavs rastislavs rastislavs approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@dlapcevic dlapcevic dlapcevic approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/major This PR introduces major new functionality to Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.