Skip to content

bugtool: dump tail-call map for bpf_wireguard #36183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

bugtool: dump tail-call map for bpf_wireguard #36183

merged 1 commit into from
Nov 28, 2024

Conversation

julianwiedmann
Copy link
Member

This was added with #33426.

@julianwiedmann
bugtool: dump tail-call map for bpf_wireguard
e3adf58 
This was added with cilium#33426.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/bugtool Impacts gathering of data for debugging purposes. release-note/misc This PR makes changes that have no direct user impact. feature/wireguard Relates to Cilium's Wireguard feature needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 26, 2024
@julianwiedmann julianwiedmann requested a review from a team as a code owner November 26, 2024 10:34
@julianwiedmann
Copy link
Member Author

/test

jschwinger233
jschwinger233 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I don't understand why there is a _2 suffix, my cilium indeed has it.

@julianwiedmann
Copy link
Member Author

Although I don't understand why there is a _2 suffix, my cilium indeed has it.

For some reason we bake the SECLABEL identity that the program uses also into the map name. And we're currently setting SECLABEL for bpf_wireguard to WORLD_ID.

Not that any of this makes much sense to me immediately ;)

@julianwiedmann julianwiedmann added this pull request to the merge queue Nov 28, 2024
Merged via the queue into cilium:main with commit 256684c Nov 28, 2024
72 checks passed
@julianwiedmann julianwiedmann deleted the 1.17-wireguard-bugtool branch November 28, 2024 08:23
@nbusseneau nbusseneau mentioned this pull request Dec 1, 2024
Merged
8 tasks
@nbusseneau nbusseneau added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Dec 1, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 3, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/cli

Assignees
No one assigned
Labels
area/bugtool Impacts gathering of data for debugging purposes. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/wireguard Relates to Cilium's Wireguard feature release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julianwiedmann @tklauser @jschwinger233 @nbusseneau