bpf: nat: support more embedded ICMP types for DEST_UNREACH packet #36179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing DEST_UNREACH messages with an ICMP payload of unsupported type, return DROP_UNKNOWN_ICMP_CODE instead of DROP_INVALID. This helps to understand the actual problem, and allows for ignoring such drops in the cilium CLI tests. Reported-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Now that the NAT path supports a wider range of DEST_UNREACH code points, we potentially see more types of embedded ICMP messages. In the outbound NAT path, we need to reflect ICMP_ECHO messages back (which for example addressed an unreachable port on the local host). In the inbound RevNAT path we can potentially see an ICMP_ECHOREPLY reflected back to the local node, if the addressed port is no longer reachable on the remote node. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
|
/test |
jibi
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As follow-on to #35636, add support for additional types of ICMP messages that potentially get reflected back by an
DEST_UNREACHpacket.