Skip to content

envoy: Update image for SDS headermatch crash #36177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

envoy: Update image for SDS headermatch crash #36177

merged 1 commit into from
Nov 26, 2024

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Nov 26, 2024 •
edited
Loading

Update Envoy image to fix cilium-envoy crash that happened when HeaderMatch secret was updated via SDS.

While this only affects main that has enabled the use of SDS for HeaderMatch secret delivery, the bug exists in all releases.

Related: cilium/proxy#1010

@jrajahalme
envoy: Update image for SDS headermatch crash
ae12071 
Update Envoy image to fix `cilium-envoy` crash that happened when
HeaderMatch secret was updated via SDS.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added kind/bug This is a bug in the Cilium logic. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. labels Nov 26, 2024
@jrajahalme jrajahalme requested review from a team as code owners November 26, 2024 06:15
@jrajahalme
Copy link
Member Author

/test

sayboras
sayboras approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just right time for more coverage with k8s secret backend

#36040

@sayboras sayboras enabled auto-merge November 26, 2024 14:11
@sayboras sayboras added this pull request to the merge queue Nov 26, 2024
Merged via the queue into cilium:main with commit 5c0c82f Nov 26, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@nebril nebril nebril approved these changes

@sayboras sayboras sayboras approved these changes

@youngnick youngnick youngnick approved these changes

@borkmann borkmann Awaiting requested review from borkmann borkmann is a code owner automatically assigned from cilium/build

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrajahalme @gandro @nebril @sayboras @youngnick