node: Improve local node synchronizer logging #36171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn3r
approved these changes
Nov 25, 2024
The support for incremental updates of labels and annotations for the local node has an undefined behavior in case an injected label or annotation is also present as part of the k8s node. Specifically, the result value for the local node updated emitted is order dependaent. Though this limitation is well-known and documented in the commit message that added support for incremental updates, let's improve the debug level logging to help a possible future investigation in case such a label/annotation names clash happens. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
3ac44d4 to
0b03cf6
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for incremental updates of labels and annotations for the local node has an undefined behavior in case an injected label or annotation is also present as part of the k8s node. Specifically, the result value for the local node updated emitted is order dependant.
Though this limitation is well-known and documented in the commit message that added support for incremental updates, let's improve the debug level logging to help a possible future investigation in case such a label/annotation names clash happens.