envoy: Start listening on xDS socket only after endpoint restoration #36032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envoy can successfully connect to a socket as soon as the socket is listening, regardless when the accept calls on the new connections are made. Delay listening on the xDS socket until endpoints have regenerated so that the time gap between the successful xDS connection and the initial fetch of the xDS resources is less likely to hit the initial fetch timeout. This silences related warnings in the logs. Hopefully there will not be a flood of warning logs due to the increased time to successful xDS connections now. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
|
/test |
sayboras
approved these changes
Nov 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This has been reverted on
main, see #36060.Envoy can successfully connect to a socket as soon as the socket is listening, regardless when the accept calls on the new connections are made.
Delay listening on the xDS socket until endpoints have regenerated so that the time gap between the successful xDS connection and the initial fetch of the xDS resources is less likely to hit the initial fetch timeout. This silences related warnings in the logs. Hopefully there will not be a flood of warning logs due to the increased time to successful xDS connections now.