Skip to content

Conversation

pchaigno
Copy link
Member

Commit f108c0c ("ipsec: Simplify XFRM IN policies") changed what arguments are given to UpsertIPsecEndpoint for XFRM IN, but did not make the same change to the related integration test.

It's not yet clear why this test didn't fail in CI, but it's failing locally so let's fix it.

Commit f108c0c ("ipsec: Simplify XFRM IN policies") changed what
arguments are given to UpsertIPsecEndpoint for XFRM IN, but did not make
the same change to the related integration test.

It's not yet clear why this test didn't fail in CI, but it's failing
locally so let's fix it.

Reported-by: Louis DeLosSantos <louis.delos@isovalent.com>
Fixes: f108c0c ("ipsec: Simplify XFRM IN policies")
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. feature/ipsec Relates to Cilium's IPsec feature labels Nov 19, 2024
@pchaigno
Copy link
Member Author

/test

@pchaigno pchaigno marked this pull request as ready for review November 19, 2024 11:05
@pchaigno pchaigno requested a review from a team as a code owner November 19, 2024 11:05
@pchaigno pchaigno requested a review from ldelossa November 19, 2024 11:05
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 19, 2024
@pchaigno pchaigno added this pull request to the merge queue Nov 19, 2024
Merged via the queue into cilium:main with commit 8274d7f Nov 19, 2024
70 checks passed
@pchaigno pchaigno deleted the fix-xfrm-pol-in-test branch November 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake feature/ipsec Relates to Cilium's IPsec feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants