cilium-cli: fix connectivity tests for IPv6-only clusters #36026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
reviewed
Nov 19, 2024
f2ebd02 to
2a9e656
Compare
|
thanks, updated to use |
|
/test |
doniacld
approved these changes
Nov 20, 2024
|
/test |
1 similar comment
|
/test |
auto-merge was automatically disabled
November 20, 2024 22:59
Head branch was pushed to by a user without write access
2a9e656 to
16d666d
Compare
|
Rebased to try to fix CI failures Suspect my branch was out-of-date, since features CLI command got added recently |
|
/test |
Handle external CIDR and IP addresses uses IPv6.
Command used to test:
cilium connectivity test \
--external-ip "2606:4700:4700::1111" \
--external-other-ip "2606:4700:4700::1001" \
--external-cidr "2606:4700:4700::/48"
Fixes: cilium#35553
Signed-off-by: Will Daly <widaly@microsoft.com>
16d666d to
b7edc08
Compare
|
/test |
tklauser
approved these changes
Dec 10, 2024
brlbil
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle external CIDR and IP addresses uses IPv6.
Command used to test:
I used this script to create an IPv6-only cluster with Cilium in kind (adapted from delegated IPAM dual-stack E2E tests): https://gist.github.com/wedaly/26123c19baeaf62f092cdc52cf8c3c4e
This fixes all of the test failures except for
to-fqdnswhich fails trying to curl cilium.io, which doesn't currently have any IPv6 addresses.Fixes: #35553