health: add ICMP probe retries #36023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1509f0 to
2e0ba1a
Compare
2e0ba1a to
4aaf676
Compare
|
/test |
ttarczynski
reviewed
Nov 20, 2024
squeed
approved these changes
Nov 20, 2024
squeed
reviewed
Nov 20, 2024
4aaf676 to
8fea346
Compare
|
@ttarczynski updated helm value name as well as Cilium option name (I prefer to keep it consistent), PTAL |
thorn3r
approved these changes
Nov 21, 2024
marseel
reviewed
Nov 22, 2024
8fea346 to
ed90302
Compare
ttarczynski
reviewed
Nov 25, 2024
ed90302 to
3f780bf
Compare
|
/test |
To check the connectivity status of other Cilium nodes, we rely on both HTTP and ICMP probes. In both cases, a single request is sent to assess the health status of the peer. In certain environments, marking a node or an endpoint as unreachable after a single ICMP response is lost may be too aggressive, ultimately leading to the reported status flapping between "OK" and "Unreachable". The commit adds an option to configure the number of ICMP requests sent before marking a node or endpoint as unreachable. By default, the value is set to 3. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Add an option to set the number of ICMP requests to send when checking the health of a node or and endpoint, before marking them as unreachable. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
3f780bf to
5d0a509
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check the connectivity status of other Cilium nodes, we rely on both HTTP and ICMP probes. In both cases, a single request is sent to assess the health status of the peer. In certain environments, marking a node or an endpoint as unreachable after a single ICMP response is lost may be too aggressive, ultimately leading to the reported status constantly flapping between "OK" and "Unreachable".
The PR adds an option (
--health-check-icmp-failure-threshold) to configure the number of ICMP requests sent before marking a node or endpoint as unreachable. By default, this value is kept to 1, as it was before.Fixes #35996