Skip to content

update cilium overview image in README to version with updated Tetragon logo #36002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

update cilium overview image in README to version with updated Tetragon logo #36002

merged 1 commit into from
Nov 19, 2024

Conversation

paularah
Copy link
Contributor

@paularah paularah commented Nov 15, 2024 •
edited by qmonnet
Loading

This commit updates the cilium overview illustration to a version that has the updated tetragon logo

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • [x ] All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This PR updates the Cilium overview image in the README to version that has the updated Tetragon logo

README.rst: Update Cilium's intro picture with the up-to-date logo for Tetragon

@paularah paularah requested a review from a team as a code owner November 15, 2024 23:07
@paularah paularah requested a review from qmonnet November 15, 2024 23:07
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 15, 2024
qmonnet
qmonnet approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The former image had more padding, which - in my opinion - helped readers to visually dissociate it from the surrounding elements on the README. But I don't mind too much, so this is your call.

Looks good otherwise.

@qmonnet qmonnet added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Nov 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 17, 2024
@qmonnet
Copy link
Member

qmonnet commented Nov 17, 2024

/test

@maintainer-s-little-helper
Copy link

Commit 4241bdc does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 18, 2024
@paularah
update cilium overview image in README
322bdfb 
This commit updates the cilium overview illustration to a version that has the updated tetragon logo

Signed-off-by: Paul Arah <paularah.self@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 18, 2024
@paularah
Copy link
Contributor Author

paularah commented Nov 18, 2024 •
edited
Loading

The former image had more padding, which - in my opinion - helped readers to visually dissociate it from the surrounding elements on the README. But I don't mind too much, so this is your call.

Looks good otherwise.

I see. I have added padding to the image.

qmonnet
qmonnet approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@qmonnet
Copy link
Member

qmonnet commented Nov 19, 2024

/test

@qmonnet qmonnet added this pull request to the merge queue Nov 19, 2024
Merged via the queue into cilium:main with commit 18792de Nov 19, 2024
59 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paularah @qmonnet