k8s/epslices: ensure that all fields are always DeepCopied #36000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GetEndpoints() method already returns a complete DeepCopy of the underlying structures, except when two separate epslices contain information about the same address. In this case, the additional ports are not DeepCopied, but plainly assigned. While I wouldn't expect this to create problems at the moment, let's get it fixed, especially considering that the result is not DeepCopied a second time anymore [1]. While being there, let's also get rid of the unnecessary DeepCopy of the mutated object, as already guaranteed to be a DeepCopy. [1]: 3b59c26 ("service-cache: improve performance of correlateEndpoints") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
joamaki
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetEndpoints() method already returns a complete DeepCopy of the underlying structures, except when two separate epslices contain information about the same address. In this case, the additional ports are not DeepCopied, but plainly assigned. While I wouldn't expect this to create problems at the moment, let's get it fixed, especially considering that the result is not DeepCopied a second time anymore [1].
While being there, let's also get rid of the unnecessary DeepCopy of the mutated object, as already guaranteed to be a DeepCopy.
[1]: 3b59c26 ("service-cache: improve performance of correlateEndpoints")