node: Fix flake in node manager TestNodeManagerEmitStatus test
#36097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32150e9 to
762cbb2
Compare
The `TestNodeManagerEmitStatus` test did not synchronize the initial status check. This caused a fairly rare test flake where the starting node manager set the state before the test read the initial state. This caused a deadlock, because the test waited for the status to be updated by the node manager and the node manager waited for the fake NodeHandler to return. We fix this deadlock and simplify the synchronization logic by replacing two interleaving goroutines by a single goroutine. This way we make sure that we read the initial empty status before the node manager can update it. Fixes: d404ee7 ("node/manager: test: avoid future race in status") Fixes: b343558 ("nodemanager: rewrite health status test for healthv2.") Co-authored-by: David Bimmler <david.bimmler@isovalent.com> Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
762cbb2 to
ec67f82
Compare
|
/test |
thorn3r
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestNodeManagerEmitStatustest did not synchronize the initial status check. This caused a fairly rare test flake where the starting node manager set the state before the test read the initial state. This caused a deadlock, because the test waited for the status to be updated by the node manager and the node manager waited for the fake NodeHandler to return.We fix this deadlock and simplify the synchronization logic by replacing two interleaving goroutines by a single goroutine. This way we make sure that we read the initial empty status before the node manager can update it.
CC @bimmlerd
CC @tommyp1ckles