hubble: ignore some testifylint linter errors #36096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
approved these changes
Nov 21, 2024
|
/test |
The testifylint linter trips over some assertion that contain JSON data and suggtests using assert.JSONEq instead of the more generic assert.Equal. This is great in most cases as JSONEq also verifies that the JSON is valid. However, it doesn't work with newline delimted JSON. For this reason, let's selectively ignore the testify warning where this condition applies. Note that the patch also moves around some nolint instructions as they were weirdly not followed by the linter. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
3d8b7f9 to
c347810
Compare
|
/test |
kaworu
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testifylint linter trips over some assertion that contain JSON data and suggtests using assert.JSONEq instead of the more generic assert.Equal. This is great in most cases as JSONEq also verifies that the JSON is valid. However, it doesn't work with newline delimted JSON. For this reason, let's selectively ignore the testify warning where this condition applies.
Note that the patch also moves around some nolint instructions as they were weirdly not followed by the linter.
Ref: #35960, #35956