ctmap/gc: implement stream.Observable[GCEvent] for CT Map GC #36084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c50d411 to
6f62b21
Compare
|
/test |
6f62b21 to
0000e1b
Compare
|
/test |
nebril
approved these changes
Nov 21, 2024
|
@aspsk @doniacld @nathanjsweet gentle ping, could you please take a look? |
aspsk
approved these changes
Nov 25, 2024
michi-covalent
approved these changes
Nov 25, 2024
pippolo84
approved these changes
Nov 25, 2024
joestringer
reviewed
Nov 26, 2024
This commit implements stream.Observable[GCEvent] to allow external consumers to observe the GC iterations over CT maps for IPv4 and IPv6 entries. Also, it replaces purge nat entry logic with this stream.Observable implementation. Note that this commit renames Enabler interface to GCRunner and move it from gc to ctmap package to avoid circular dependency. The endpoint package can't depend on the gc package because the gc depends on the endpoint package. This is necessary to run GCRunner.Run in Endpoint.garbageCollectConntrack. (See next commit) Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
…rack This commit adds GCRunner to run GC in Endpoint.garbageCollectConntrack Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
0000e1b to
7eef2e0
Compare
|
/test |
tommyp1ckles
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements stream.Observable[GCEvent] to allow external consumers to observe the GC iterations over CT maps
for IPv4 and IPv6 entries. Also, it replaces purge nat entry logic with this stream.Observable implementation.