cilium-cli: add external-other-target arg to connectivity tests #36080
+9
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
/ci-integration |
d07e980 to
c70943b
Compare
4396608 to
2c6c151
Compare
|
/test |
derailed
approved these changes
Dec 9, 2024
|
@sayboras 🏓 would be nice to see this merged, wdyt? |
Allow overriding the "blocked" domain in the test using `--external-other-target` instead of hard-coding cilium.io Signed-off-by: Will Daly <widaly@microsoft.com>
2c6c151 to
41fb486
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding the "blocked" domain in the test using
--external-other-targetinstead of hard-coding cilium.ioThis is a workaround for failing
to-fqdntests in IPv6-only cluster. These fail because "cilium.io" doesn't have an AAAA record, socurltries to connect to the IPv4 address and fails with a different error code than the one expected by the test (network unreachable instead of timeout).Fixes: #35553