-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add feature tracking in Cilium Operator as prometheus metrics #36077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test |
Pull request was converted to draft
5feaf60
to
15ccb19
Compare
/test |
15ccb19
to
733ab1c
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for Ingress and Gateway related changes
… features With a dedicate package to detect which features are enabled, we will be able to report, in form of metrics, from the agents, which features are enabled. Once all features are tracked, it will give us the ability to track down which features are being tested in our CI and the ones that are lacking coverage. Signed-off-by: André Martins <andre@cilium.io>
Track if IngressController is enabled in Cilium Operator Signed-off-by: André Martins <andre@cilium.io>
Track if LBIPAM is enabled in Cilium Operator Signed-off-by: André Martins <andre@cilium.io>
Track if L7AwareTrafficManagement is enabled in Cilium Operator Signed-off-by: André Martins <andre@cilium.io>
Track if NodeIPAM is enabled in Cilium Operator Signed-off-by: André Martins <andre@cilium.io>
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPAM look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Follow up of #35852 but this time for Cilium Operator. I've split in multiple commits so it's easier for each sig to review their section.
Note for reviewers: Review on a per-commit basis to make sure the feature of your sig is being detected correctly.
Features Checklist