Skip to content

Conversation

aanm
Copy link
Member

@aanm aanm commented Nov 20, 2024

Follow up of #35852 but this time for Cilium Operator. I've split in multiple commits so it's easier for each sig to review their section.

Note for reviewers: Review on a per-commit basis to make sure the feature of your sig is being detected correctly.

Features Checklist

  • Enable Gateway API (@cilium/sig-servicemesh)
  • Enable Ingress Controller (@cilium/sig-servicemesh)
  • Enable LBIPAM (@cilium/sig-ipam)
  • Enable L7AwareTrafficManagement (@cilium/sig-servicemesh)
  • Enable NodeIPAM (@cilium/sig-ipam)

@aanm aanm added area/CI Continuous Integration testing issue or flake release-note/major This PR introduces major new functionality to Cilium. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/epic This tracks a significant amount of work. cilium-cli This PR contains changes related with cilium-cli labels Nov 20, 2024
@aanm aanm requested review from a team as code owners November 20, 2024 17:49
@aanm
Copy link
Member Author

aanm commented Nov 20, 2024

/test

@aanm aanm enabled auto-merge November 20, 2024 17:50
@aanm aanm marked this pull request as draft November 21, 2024 11:47
auto-merge was automatically disabled November 21, 2024 11:47

Pull request was converted to draft

@aanm aanm force-pushed the pr/aanm/features-operator branch from 5feaf60 to 15ccb19 Compare November 21, 2024 15:42
@aanm
Copy link
Member Author

aanm commented Nov 21, 2024

/test

@aanm aanm force-pushed the pr/aanm/features-operator branch from 15ccb19 to 733ab1c Compare November 21, 2024 15:46
@aanm
Copy link
Member Author

aanm commented Nov 21, 2024

/test

@aanm aanm marked this pull request as ready for review November 21, 2024 15:47
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for Ingress and Gateway related changes

aanm added 5 commits November 22, 2024 14:18
… features

With a dedicate package to detect which features are enabled, we will be
able to report, in form of metrics, from the agents, which features are
enabled. Once all features are tracked, it will give us the ability to
track down which features are being tested in our CI and the ones that
are lacking coverage.

Signed-off-by: André Martins <andre@cilium.io>
Track if IngressController is enabled in Cilium Operator

Signed-off-by: André Martins <andre@cilium.io>
Track if LBIPAM is enabled in Cilium Operator

Signed-off-by: André Martins <andre@cilium.io>
Track if L7AwareTrafficManagement is enabled in Cilium Operator

Signed-off-by: André Martins <andre@cilium.io>
Track if NodeIPAM is enabled in Cilium Operator

Signed-off-by: André Martins <andre@cilium.io>
@aanm
Copy link
Member Author

aanm commented Nov 22, 2024

/test

Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPAM look good

Copy link
Contributor

@dlapcevic dlapcevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for operator

@aanm aanm enabled auto-merge November 26, 2024 17:45
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aanm aanm added this pull request to the merge queue Nov 26, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 26, 2024
Merged via the queue into main with commit 3457914 Nov 26, 2024
272 of 273 checks passed
@aanm aanm deleted the pr/aanm/features-operator branch November 26, 2024 20:38
@aanm aanm added needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 29, 2024
@aanm aanm added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 16, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 16, 2024
@aanm aanm mentioned this pull request Dec 17, 2024
14 tasks
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Dec 18, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/metrics Impacts statistics / metrics gathering, eg via Prometheus. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. cilium-cli This PR contains changes related with cilium-cli kind/epic This tracks a significant amount of work. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/major This PR introduces major new functionality to Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants