Skip to content

Update push-chart-ci.yaml to pass variables through the environmnet #36061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

Update push-chart-ci.yaml to pass variables through the environmnet #36061

merged 1 commit into from
Nov 21, 2024

Conversation

pwntester
Copy link

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Passes chart version as an env variable to prevent script injection since the contents of VERSION file may be controlled by external users.

<!-- Enter the release note text here if needed or remove this section! -->

Update push-chart-ci.yaml
b91302c 
Signed-off-by: Alvaro Muñoz <pwntester@github.com>
@pwntester pwntester requested review from a team as code owners November 20, 2024 09:31
@pwntester pwntester requested review from aanm and brlbil November 20, 2024 09:31
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 20, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 20, 2024
@pwntester pwntester changed the title Update push-chart-ci.yaml Update push-chart-ci.yaml to pass variables through the environmnet Nov 20, 2024
@ferozsalam ferozsalam added the release-note/ci This PR makes changes to the CI. label Nov 20, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 20, 2024
@ferozsalam
Copy link
Contributor

/test

@joestringer joestringer added this pull request to the merge queue Nov 21, 2024
Merged via the queue into cilium:main with commit e753e67 Nov 21, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferozsalam ferozsalam ferozsalam approved these changes

@joestringer joestringer joestringer approved these changes

@aanm aanm Awaiting requested review from aanm aanm is a code owner automatically assigned from cilium/github-sec

@brlbil brlbil Awaiting requested review from brlbil brlbil is a code owner automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwntester @ferozsalam @joestringer