Envoy: demote initial fetch timeout warning #36060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 428e7e7 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
9825e27 to
4d4a363
Compare
|
Commit 428e7e7 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
4d4a363 to
6d9b8e0
Compare
This reverts commit 40ac5c3. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Demote the expected initial fetch timeout warning due to Cilium Agent delaying serving resources until endpoints have regenerated. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
We can start waiting for acknowledgements as soon as all endpoints have regenerated, there is no need to wait for the first xDS request to be received. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
6d9b8e0 to
84e77ee
Compare
|
/test |
sayboras
approved these changes
Nov 22, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #36032 as it did not resolve the issue with Envoy initial fetch timeout warnings. Demote those warnings in the inlined logs from the embedded cilium-envoy instead.
Start waiting for Envoy acknowledgements as soon as endpoints have regenerated, rather than only when the first request on the xDS stream has been received.
Note that any proxied DNS requests will not wait for acknowledgements if issued before endpoints have regenerated, and even if they did, the maximum delay for passing the DNS response to the source pod is shorter than the time span allowed for endpoint regeneration.
We could start serving xDS resources sooner if we computed policies for the regenerated endpoints first, after which we could start serving xDS resources to envoy. Then the endpoints could take the time to recompute their bpf programs etc.
Fixes: #36032
Fixes: #35984