Skip to content

helm: Remove redundant attribute in TLS configuration #36041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

sayboras
Copy link
Member

The attribute tls.secretSync.secretsNamespace.enabled is not used, and seems to be covered by tls.secretSync.enabled instead.

Fixes: 9d6cdfc

The attribute tls.secretSync.secretsNamespace.enabled is not used, and
seems to be covered by tls.secretSync.enabled instead.

Fixes: 9d6cdfc

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 19, 2024
@sayboras sayboras added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Nov 19, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 19, 2024
@sayboras sayboras marked this pull request as ready for review November 19, 2024 13:04
@sayboras sayboras requested review from a team as code owners November 19, 2024 13:04
@sayboras sayboras requested review from joamaki and squeed November 19, 2024 13:04
@sayboras
Copy link
Member Author

/test

@sayboras sayboras requested a review from youngnick November 19, 2024 14:40
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 21, 2024
@sayboras sayboras added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit ace10fd Nov 21, 2024
281 checks passed
@sayboras sayboras deleted the pr/tammach/clean-up-helm-tls branch November 21, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants