Skip to content

gha: Add coverage for policy secret sync #36040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 19, 2024

This commit is to make sure that we have the coverage for policy secret
sync enabled and disabled.

Relates: #35513

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 19, 2024
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Nov 19, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 19, 2024
@sayboras sayboras force-pushed the pr/tammach/ci-tls-secret-sync branch 4 times, most recently from 654f59b to 4946ef2 Compare November 19, 2024 13:18
@sayboras
Copy link
Member Author

/ci-e2e-upgrade

@sayboras sayboras marked this pull request as ready for review November 19, 2024 14:58
@sayboras sayboras requested review from a team as code owners November 19, 2024 14:58
@sayboras sayboras requested review from aanm and brlbil November 19, 2024 14:58
@sayboras
Copy link
Member Author

/test

@sayboras sayboras force-pushed the pr/tammach/ci-tls-secret-sync branch from 4946ef2 to 85b64e1 Compare November 25, 2024 04:48
@sayboras sayboras marked this pull request as draft November 25, 2024 04:48
@sayboras sayboras force-pushed the pr/tammach/ci-tls-secret-sync branch 6 times, most recently from a376ae2 to 27f56f7 Compare November 25, 2024 10:03
@sayboras sayboras requested a review from aanm November 25, 2024 10:37
@sayboras
Copy link
Member Author

/ci-e2e-upgrade

@sayboras sayboras marked this pull request as ready for review November 25, 2024 10:38
This commit is to make sure that we have the coverage for policy secret
sync enabled and disabled.

Relates: #35513
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/ci-tls-secret-sync branch from 27f56f7 to 98e34c1 Compare November 25, 2024 11:24
@sayboras sayboras requested a review from aanm November 25, 2024 11:26
@sayboras
Copy link
Member Author

/ci-e2e-upgrade

@aanm aanm enabled auto-merge November 25, 2024 16:10
@aanm
Copy link
Member

aanm commented Nov 25, 2024

/test

@aanm aanm added this pull request to the merge queue Nov 25, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 25, 2024
Merged via the queue into main with commit f6c93df Nov 25, 2024
96 checks passed
@aanm aanm deleted the pr/tammach/ci-tls-secret-sync branch November 25, 2024 23:57
Comment on lines +141 to +143
cilium connectivity test --test="l7|sni|check-log-errors" \
--junit-file "cilium-junits/${{ env.job_name }}-without-secret-sync.xml" \
--junit-property github_job_step="Run connectivity test with secret sync disabled"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brlbil @cilium/ci-structure I would expect CI structure review to catch that this workflow was not reusing ${{ steps.vars.outputs.connectivity_test_defaults }} and hence introduced a few CI bugs here such as failing to capture sysdump on failure.

Fix is here: #41036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants