-
Notifications
You must be signed in to change notification settings - Fork 3.4k
docs: lrp: fix kernel version requirement for skipRedirectFromBackend #35921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
/test |
/ci-multi-pool |
The skipRedirectFromBackend requires the use of getsockopt() with SO_NETNS_COOKIE option which is available in the kernel >= 5.12. This commit fixes the LRP doc accordingly. Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
4240609
to
ea8b6c4
Compare
/test |
qmonnet
approved these changes
Nov 13, 2024
14 tasks
ysksuzuki
added a commit
to ysksuzuki/cilium
that referenced
this pull request
Nov 25, 2024
The PR cilium#35921 fixed the kernel version requirement for skipRedirectFromBackend but the warning log remains with the incorrect kernel version. This commit fixes it. Fixes: cilium#35211 Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
nbusseneau
pushed a commit
to nbusseneau/cilium
that referenced
this pull request
Dec 1, 2024
[ upstream commit 03f2494 ] The PR cilium#35921 fixed the kernel version requirement for skipRedirectFromBackend but the warning log remains with the incorrect kernel version. This commit fixes it. Fixes: cilium#35211 Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
pushed a commit
to nbusseneau/cilium
that referenced
this pull request
Dec 1, 2024
[ upstream commit 03f2494 ] The PR cilium#35921 fixed the kernel version requirement for skipRedirectFromBackend but the warning log remains with the incorrect kernel version. This commit fixes it. Fixes: cilium#35211 Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
[ upstream commit 03f2494 ] The PR #35921 fixed the kernel version requirement for skipRedirectFromBackend but the warning log remains with the incorrect kernel version. This commit fixes it. Fixes: #35211 Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/lrp
Impacts Local Redirect Policy.
backport-done/1.16
The backport for Cilium 1.16.x for this PR is done.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skipRedirectFromBackend requires getsockopt() with SO_NETNS_COOKIE option which available in the kernel >= 5.12. This commit fixes the LRP doc accordingly.
The kernel commit which exposes
SO_NETNS_COOKIE
to the userspacetorvalds/linux@e8b9eab