Skip to content

Conversation

ysksuzuki
Copy link
Member

@ysksuzuki ysksuzuki commented Nov 12, 2024

The skipRedirectFromBackend requires getsockopt() with SO_NETNS_COOKIE option which available in the kernel >= 5.12. This commit fixes the LRP doc accordingly.

The kernel commit which exposes SO_NETNS_COOKIE to the userspace
torvalds/linux@e8b9eab

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 12, 2024
@ysksuzuki ysksuzuki added release-note/misc This PR makes changes that have no direct user impact. area/lrp Impacts Local Redirect Policy. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 12, 2024
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki
Copy link
Member Author

/ci-multi-pool

The skipRedirectFromBackend requires the use of getsockopt() with
SO_NETNS_COOKIE option which is available in the kernel >= 5.12.
This commit fixes the LRP doc accordingly.

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@ysksuzuki ysksuzuki force-pushed the lrp-doc-netns-cookie branch from 4240609 to ea8b6c4 Compare November 13, 2024 00:08
@ysksuzuki
Copy link
Member Author

/test

@ysksuzuki ysksuzuki marked this pull request as ready for review November 13, 2024 00:48
@ysksuzuki ysksuzuki requested review from a team as code owners November 13, 2024 00:48
@ysksuzuki ysksuzuki requested review from joamaki and qmonnet November 13, 2024 00:48
@qmonnet qmonnet added this pull request to the merge queue Nov 13, 2024
Merged via the queue into cilium:main with commit 9ffe59b Nov 13, 2024
67 checks passed
@rastislavs rastislavs mentioned this pull request Nov 20, 2024
14 tasks
@rastislavs rastislavs added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 20, 2024
ysksuzuki added a commit to ysksuzuki/cilium that referenced this pull request Nov 25, 2024
The PR cilium#35921 fixed the kernel version requirement for
skipRedirectFromBackend but the warning log remains with
the incorrect kernel version. This commit fixes it.

Fixes: cilium#35211

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2024
The PR #35921 fixed the kernel version requirement for
skipRedirectFromBackend but the warning log remains with
the incorrect kernel version. This commit fixes it.

Fixes: #35211

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Nov 26, 2024
nbusseneau pushed a commit to nbusseneau/cilium that referenced this pull request Dec 1, 2024
[ upstream commit 03f2494 ]

The PR cilium#35921 fixed the kernel version requirement for
skipRedirectFromBackend but the warning log remains with
the incorrect kernel version. This commit fixes it.

Fixes: cilium#35211

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau pushed a commit to nbusseneau/cilium that referenced this pull request Dec 1, 2024
[ upstream commit 03f2494 ]

The PR cilium#35921 fixed the kernel version requirement for
skipRedirectFromBackend but the warning log remains with
the incorrect kernel version. This commit fixes it.

Fixes: cilium#35211

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 3, 2024
[ upstream commit 03f2494 ]

The PR #35921 fixed the kernel version requirement for
skipRedirectFromBackend but the warning log remains with
the incorrect kernel version. This commit fixes it.

Fixes: #35211

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lrp Impacts Local Redirect Policy. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants