daemon: Catch panics in shell handler #35918
Merged
+25
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
To make sure that the shell commands cannot bring down the agent,
catch the panics in the handler. On panic log it and also send it
over the connection:
cilium> help tiuheot
PANIC: runtime error: invalid memory address or nil pointer dereference
goroutine 1684 [running]:
github.com/cilium/cilium/daemon/cmd.shell.handleConn.func2()
.../cilium/cilium/daemon/cmd/shell.go:109 +0x85
panic({0x3cba7e0?, 0x75d9af0?})
.../share/go/src/runtime/panic.go:785 +0x132
github.com/cilium/hive/script.(*Engine).ListCmds(0xc000d68a38, ...
.../cilium/cilium/vendor/github.com/cilium/hive/script/engine.go:731 +0x14c
...
Fixes: 897fcb7 ("daemon,cilium-dbg: Cilium shell")
Signed-off-by: Jussi Maki <jussi@isovalent.com>
No point including all the commands as many of them are really only useful in tests plus they clutter up the help. Signed-off-by: Jussi Maki <jussi@isovalent.com>
3510597 to
f194645
Compare
|
/test |
ldelossa
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure that the shell commands cannot bring down the agent, catch the panics in the handler. On panic log it and also send it over the connection: