Skip to content

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Nov 12, 2024

Once this PR is merged, a GitHub action will update the labels of these PRs:

 28155 35646 35679

mhofstetter and others added 2 commits November 12, 2024 11:46
[ upstream commit 76aad59 ]

[ backporter's notes: hit minor conflict due to the presence
  of 8cf3df4 ("Makefile fix kind-install-cilium-fast target"),
  resolved ignoring the associated hunk, as already up-to-date. ]

The Make targets to deploy Cilium into a kind cluster are
using the following Helm values files.

* contrib/testing/kind-values.yaml
* contrib/testing/kind-fast.yaml

These contain reasonable defaults. Nevertheless, it would be
great to be able to define additional helm values without
having to modify the existing files.

Therefore, this commit introduces the possibilitiy to define a
user-defined values file that is added to the list of helm values
files.

* contrib/testing/kind-custom.yaml

To prevent users from committing the file, it's ignored by Git.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit 03bde2b ]

[ backproter's notes: applied the changes to the main Makefile, rather
  than Makefile.kind that did not exist in the v1.14 tree. ]

Simplify locally testing Cilium configured in kvstore mode via the
introduction of a dedicated `kind-kvstore-install-cilium` target,
which takes care of setting up an etcd pod running in host network
(pinned to a control plane node) and configuring Cilium to target it.

The creation and deletion of the etcd pod is delegated to the dedicated
`kind-start-kvstore` and `kind-stop-kvstore` commands.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added kind/backports This PR provides functionality previously merged into master. backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. labels Nov 12, 2024
@giorio94
Copy link
Member Author

/test-backport-1.14

@giorio94 giorio94 force-pushed the pr/v1.14-backport-2024-11-12-11-42 branch from 4bee843 to 30ee322 Compare November 12, 2024 12:59
@giorio94
Copy link
Member Author

/test-backport-1.14

[ upstream commit 535e7f1 ]

[ backporter's notes: applied equivalent changes to the Conformance E2E
  workflow, as the upgrade/downgrade one does not exist in v1.14. ]

Modify a few matrix entries of the Cilium E2E Upgrade workflow to
configure Cilium in kvstore mode, to cover this functionality here
as well in addition to the clustermesh workflows. In detail, the
etcd instance is executed as a pod running in host network, which
is setup via the `kind-kvstore-start` makefile target. The matrix
entries are selected trying to cover the most common combinations,
that is native-routing/tunneling, KPR off/on and wireguard off/on,
and avoiding incompatible options (mainly Egress Gateway).

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit 2056fa9 ]

[ backporter's notes: hit minor conflicts due to different surrounding
  context, adapted as appropriate; additionally configured the matrix
  entries in the individual workflow files, as ipsec/configs.yaml did
  not exist in the v1.14 tree. ]

Modify a few matrix entries of the Conformance IPSec and IPSec Upgrade
workflows to configure Cilium in kvstore mode, to cover this functionality
here as well in addition to the E2E and clustermesh workflows. In detail,
the etcd instance is executed as a pod running in host network, which
is setup via the `kind-kvstore-start` makefile target. The matrix entries
are selected to cover both native routing and tunneling, while avoiding
incompatible options (mainly Egress Gateway and Mutual Auth).

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the pr/v1.14-backport-2024-11-12-11-42 branch from 30ee322 to 8e0ac3c Compare November 12, 2024 13:58
@giorio94
Copy link
Member Author

/test-backport-1.14

@giorio94 giorio94 marked this pull request as ready for review November 12, 2024 15:34
@giorio94 giorio94 requested review from a team as code owners November 12, 2024 15:34
@giorio94 giorio94 requested a review from brlbil November 12, 2024 15:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 12, 2024
@sayboras sayboras merged commit 36e18a2 into v1.14 Nov 12, 2024
240 checks passed
@sayboras sayboras deleted the pr/v1.14-backport-2024-11-12-11-42 branch November 12, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants