Skip to content

kvstore: drop obsolete removal of legacy prefixes #35995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

giorio94
Copy link
Member

When running in kvstore mode, Cilium agents attempt to remove legacy prefixes from the kvstore itself at startup. Given that this cleanup logic has been in place for almost 7 years now [1], it is fair to assume that it is no longer necessary at this point. Hence, let's drop it, for simplicity.

[1]: 7ccf877 ("kvstore: New kvstore abstraction API")

When running in kvstore mode, Cilium agents attempt to remove legacy
prefixes from the kvstore itself at startup. Given that this cleanup
logic has been in place for almost 7 years now [1], it is fair to
assume that it is no longer necessary at this point. Hence, let's
drop it, for simplicity.

[1]: 7ccf877 ("kvstore: New kvstore abstraction API")

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/kvstore Impacts the KVStore package interactions. labels Nov 15, 2024
@giorio94 giorio94 requested review from a team as code owners November 15, 2024 08:19
@giorio94 giorio94 requested a review from marseel November 15, 2024 08:19
@giorio94
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 18, 2024
@aanm aanm added this pull request to the merge queue Nov 18, 2024
Merged via the queue into cilium:main with commit 66d5d41 Nov 18, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kvstore Impacts the KVStore package interactions. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants