test: FQDN: prevent names from being GCd when restarting #35985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on names not being eligible for garbage collection when restarting. However, if the DNS name being tested has a low TTL, this can trigger this accidentally. So, we bump the idle grace period as well as the min TTL, so that IPs won't be prematurely GCd even if they are no longer present in the conntrack map. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
|
/test |
gandro
approved these changes
Nov 14, 2024
sayboras
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on names not being eligible for garbage collection when restarting. However, if the DNS name being tested has a low TTL, this can trigger this accidentally.
So, we bump the idle grace period as well as the min TTL, so that IPs won't be prematurely GCd even if they are no longer present in the conntrack map.
(this should get
maingreen again)