policy: No-op Identity Allocator #35973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
341bd73 to
db8efe6
Compare
|
/test |
|
Clustermesh failures seems like bug introduced in this PR: corresponds to: |
I see. Interesting. I only changed from struct pointer (*RemoteCache) to interface (RemoteIDCache). |
Yes, you can call method on nil pointer, but not on nil interface. On nil interface it causes panic. |
ce39b1d to
edd01a8
Compare
marseel
approved these changes
Nov 19, 2024
tklauser
reviewed
Nov 20, 2024
tklauser
requested changes
Nov 20, 2024
tklauser
requested changes
Nov 20, 2024
tklauser
approved these changes
Nov 20, 2024
**Description** As part of the network policy modularization and decoupling of the network policy enforcement system from the endpoint, the no-op allocator aims to provide a possibility of disabling the identity allocation system when network policies are disabled. **Motivation** The scalability of network policy feature is limited when the scalability dimensions, # of nodes and pod churn rate, are stretched. Cilium has many networking features that scale better, or are unaffected by these scalability dimensions. Currently, disabling network policies to reach higher scale for other features is the only feasible solution. Note: The plan is to improve scalability of network policies, so that it can reach higher scales that are required. **Follow-up** Subsequently, the plan is to agree on a configuration set that would determine if the identity allocation system should be disabled, and put the no-op allocator to use. Proposed config: - EnablePolicy=never - DisableCiliumEndpointCRD=true - EnableK8sNetworkPolicy=false - EnableCiliumNetworkPolicy=false - EnableCiliumClusterwideNetworkPolicy=false Signed-off-by: Dorde Lapcevic <dordel@google.com>
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #33360
Description
As part of the network policy modularization and decoupling of the network policy enforcement system from the endpoint, the no-op allocator aims to provide a possibility of disabling the identity allocation system when network policies are disabled.
Motivation
The scalability of network policy feature is limited when the scalability dimensions, # of nodes and pod churn rate, are stretched. Cilium has many networking features that scale better, or are unaffected by these scalability dimensions. Currently, disabling network policies to reach higher scale for other features is the only feasible solution.
Note: The plan is to improve scalability of network policies, so that it can reach higher scales that are required.
Follow-up
Subsequently, the plan is to agree on a configuration set that would determine if the identity allocation system should be disabled, and put the no-op allocator to use.
Proposed config:
Signed-off-by: Dorde Lapcevic <dordel@google.com>