bgp: fix race in bgp stores #35971
Merged
bgp: fix race in bgp stores #35971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyp1ckles
approved these changes
Nov 13, 2024
|
/test |
b4e34f3 to
4435c71
Compare
Resource store need to be protected by mutex, it is read and written by different go routines. Since resource.Store is blocking call, store is nil till this call is completed. In the meantime, reconciliation will fail because store is nil. Adding mutex around resource.Store will block reconciliation till store is initialized. This prevents the case where reconciliation is aborted and never retried. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
4435c71 to
a6dde07
Compare
|
/test |
14 tasks
6 tasks
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource store need to be protected by mutex, it is read and written by different go routines. Since resource.Store is blocking call, store is nil till this call is completed. In the meantime, reconciliation will fail because store is nil. Adding mutex around resource.Store will block reconciliation till store is initialized. This prevents the case where reconciliation is failed and never retried.
Fixes: #35607
Fixes: #35872