[v1.15] tests-e2e-upgrade: No longer use secondary network for test 14 #35969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci-e2e-upgrade |
|
/ci-e2e-upgrade |
ca7e046 to
6fe07ae
Compare
|
/test-backport-1.15 |
aanm
approved these changes
Nov 13, 2024
|
/ci-e2e-upgrade |
1 similar comment
|
/ci-e2e-upgrade |
|
Seems like this now causes an issue with Cilium's installation 😭 https://github.com/cilium/cilium/actions/runs/11821452018/job/32936271712 Back to draft |
auto-merge was automatically disabled
November 13, 2024 16:32
Pull request was converted to draft
This comment was marked as resolved.
This comment was marked as resolved.
PR #35893 fixed an escaping issue in that workflow but it seems like the correct escaping (which made `--secondary-network` work again) seem to have exposed an underlying issue with that configuration where it started failing in `north-south-loadbalancing-with-l7-policy` (#35967). In v1.16, we seemed to have fixed that problem in commit 1c42d6f, but in v1.15 running a different kernel version breaks the workflow. Therefore, this commit reverts the test back to not using a secondary network which is what it was effectively running previously. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
0ee3263 to
d581910
Compare
|
/test-backport-1.15 |
brlbil
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #35893 fixed an escaping issue in that workflow but it seems like the correct escaping (which made
--secondary-networkwork again) seem to have exposed an underlying issue with that configuration where it started failing innorth-south-loadbalancing-with-l7-policy(#35967).In v1.16, we seemed to have fixed that problem in commit 1c42d6f, but in v1.15 running a different kernel version breaks the workflow to the point where it cannot even install Cilium anymore.
Therefore, this commit reverts the test back to not using a secondary network which is what it was effectively running previously.