Skip to content

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Nov 13, 2024

PR #35956 updates golangci-lint to v1.62.0. This new version surfaces a new lint error, which this PR aims to address:

encoded-compare: use require.JSONEq (testifylint)

@rolinh rolinh added the release-note/ci This PR makes changes to the CI. label Nov 13, 2024
@rolinh rolinh force-pushed the pr/rolinh/fix-testifylint-errors branch from d559eaa to 3636b8c Compare November 13, 2024 13:36
@rolinh rolinh marked this pull request as ready for review November 13, 2024 14:04
@rolinh rolinh requested review from a team as code owners November 13, 2024 14:04
@rolinh
Copy link
Member Author

rolinh commented Nov 13, 2024

/test

@aanm aanm added needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 13, 2024
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/fix-testifylint-errors branch from 3636b8c to 9efe5ae Compare November 13, 2024 14:36
@rolinh
Copy link
Member Author

rolinh commented Nov 13, 2024

/test

@rolinh rolinh enabled auto-merge November 13, 2024 15:46
@aanm aanm disabled auto-merge November 21, 2024 11:28
@aanm aanm merged commit fa457f3 into main Nov 21, 2024
135 checks passed
@aanm aanm deleted the pr/rolinh/fix-testifylint-errors branch November 21, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants