ci: use the VERSION file from the PR branch in push-charts-ci.yaml #35950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Push Chart CI workflow uses the default branch when running print-chart-version.sh. Other workflows checkout the PR branch for the same script. The print-chart-version.sh script uses the VERSION file at the repo root to determine the tags of the Helm charts that are pushed, which means that we were seeing inconsistencies between the chart tag that was being pushed and the chart tags that other workflows were looking for. This change to the Push Chart CI workflow copies the VERSION file from the PR branch into the location that print-chart-version.sh expects, so that all workflows are now getting the VERSION from the same file. Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
|
/test |
aanm
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Push Chart CI workflow uses the default branch when running
print-chart-version.sh. Other workflows checkout the PR branch for the same script. Theprint-chart-version.shscript uses the VERSION file at the repo root to determine the tags of the Helm charts that are pushed, which means that we were seeing inconsistencies between the chart tag that was being pushed and the chart tags that other workflows were looking for when PRs are opened against version branches.This change to the Push Chart CI workflow copies the VERSION file from the PR branch into the location that
print-chart-version.shexpects, so that all workflows are now getting the VERSION from the same file.