node_local_store: prevent racey tests while using mock node store. #35945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
When creating the test node store, the node is stored and is immediately ready via Get. However, a observable event is also emitted at the same time. In the hubble node observer tests, the node was updated directly the update function - however in some cases this would be overwritten by the initial node event if the observable emit call was scheduled late. Instead, we update the store directly by mutating the node which forces the updates to be serialized in the order they are called. Fixes: #34092 Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
a15d7e8 to
3776f39
Compare
|
/test |
kaworu
approved these changes
Nov 13, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the test node store, the node is stored and is immediately
ready via Get.
However, a observable event is also emitted at the same time.
In the hubble node observer tests, the node was updated directly the
update function - however in some cases this would be overwritten
by the initial node event if the observable emit call was scheduled
late.
Instead, we update the store directly by mutating the node which
forces the updates to be serialized in the order they are called.
Fixes: #34092