Skip to content

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Nov 7, 2024

For v1.16+ we expect all supported & CI-tested kernels to have the required BPF functionality. Thus it should be safe to configure Cilium with the default behavior ('reject'), and not trigger a warning in CI.

As the warning should no longer occur, remove the entry from the ignore list so that we can catch it.

@julianwiedmann julianwiedmann added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. area/loadbalancing Impacts load-balancing and Kubernetes service implementations labels Nov 7, 2024
@julianwiedmann julianwiedmann requested a review from a team as a code owner November 7, 2024 08:23
@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/svc-reject-warning branch from 15d1be9 to fdd7294 Compare November 7, 2024 08:25
For v1.16+ we expect all supported & CI-tested kernels to have the
required BPF functionality. Thus it should be safe to configure Cilium
with the default behavior ('reject'), and not trigger a warning in CI.

As the warning should no longer occur, remove the entry from the ignore
list so that we can catch it.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/svc-reject-warning branch from fdd7294 to af1b991 Compare November 7, 2024 08:34
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added this pull request to the merge queue Nov 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 7, 2024
Merged via the queue into main with commit 17c6c92 Nov 7, 2024
122 checks passed
@julianwiedmann julianwiedmann deleted the pr/jwi/main/svc-reject-warning branch November 7, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/loadbalancing Impacts load-balancing and Kubernetes service implementations ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants